-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support of parametric hardware models #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoferigo
force-pushed
the
feature/kin_dyn_parameters
branch
2 times, most recently
from
March 8, 2024 15:16
8952c1b
to
9044c86
Compare
diegoferigo
force-pushed
the
feature/kin_dyn_parameters
branch
6 times, most recently
from
March 12, 2024 10:04
602a0d3
to
ed0cd77
Compare
diegoferigo
force-pushed
the
feature/kin_dyn_parameters
branch
3 times, most recently
from
March 12, 2024 16:01
81c8246
to
6f570bb
Compare
diegoferigo
force-pushed
the
feature/kin_dyn_parameters
branch
4 times, most recently
from
March 14, 2024 10:51
35df971
to
9568eb7
Compare
diegoferigo
force-pushed
the
feature/kin_dyn_parameters
branch
from
March 14, 2024 11:59
63246c3
to
756b69f
Compare
flferretti
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Diego, LGTM! I just wrote some minor comments
diegoferigo
force-pushed
the
feature/kin_dyn_parameters
branch
2 times, most recently
from
March 14, 2024 15:37
61dd60d
to
1c00e1e
Compare
Co-authored-by: Filippo Luca Ferretti <[email protected]>
diegoferigo
force-pushed
the
feature/kin_dyn_parameters
branch
from
March 14, 2024 15:48
1c00e1e
to
7b6a88b
Compare
This was referenced Mar 18, 2024
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, JaxSim builds three models from a model description (URDF, SDF):
jaxsim.parsers.descriptions.ModelDescription
jaxsim.physics.model.PhysicsModel
jaxsim.api.model.JaxSimModel
(functional replacement of the formerjaxsim.high_level.model.Model
)One of the objective of the new functional APIs (#108) is to expose a set of hardware parameters so that downstream projects can compute their gradient by exploiting automatic differentiation.
This PR introduces the initial support towards this goal. Particularly:
KinDynParameters
class, stored insideJaxSimModel
, that will soon replacePhysicsModel
. Its aim is to act as a simple container of joint, link, and contact parameters, with useful setters for updating them without re-creating from scratch a newJaxSimModel
object.PhysicsModel
toJaxSimModel
(will be finalized in #112).📚 Documentation preview 📚: https://jaxsim--101.org.readthedocs.build//101/